GH2 624 reporting in

[JohnnyDmonic]

Might just be my download or something went wierd unzipping, but I've got formatting errors on all 3 of the LongRangeScanners, for instance on the Crown:

   ECM 6
mass -1             LongRangeScanner 4

Something like that (but with those wierd little square zero looking symbols after the -1).  They do seem to work fine, it just looks odd.  thought it had mass -100 for a moment or two.

[vcappe]

That's because the new lines use unix style end of line (CR) rather than dos style end of line (CRLF).
The game code doesn't care either way.

[vcappe]

There is a bug in the way the sensor bonus is calculated for missile weapons.
In effects.pp around line 1241, it does:

Code: [Select]

        { Missiles use sensor rating instead of targeting rating. }
        if ( Attacker^.S = GS_Missile ) and ( AMaster^.G = GG_Mecha ) then begin
            AddModifier( 'sensor' , ( MechaSensorRating( AMaster ) - MechaTargeting( AMaster ) ) );
        end;^M

That "- MechTargeting( AMaster )" should not be there. That BuruBuru got supernaturally accurate with missiles after i hit it a few times with a particule cannon.

[Joseph Hewitt]

There is a bug in the way the sensor bonus is calculated for missile weapons.
In effects.pp around line 1241, it does:

...

That "- MechTargeting( AMaster )" should not be there. That BuruBuru got supernaturally accurate with missiles after i hit it a few times with a particule cannon.

Oh, I see the problem: the "-MechaTargeting( AMaster )" isn't a mistake per se, since MechaTargeting gets added at a different point in the process (it's added to the SkillValue). The problem comes in because the skill value has a minimum value of 1, so if the TR reduces the value below 1 adding it again in the CalcTotalModifiers function ends up giving a bonus.

[JohnnyDmonic]

Arena Challenger the smuggler, the sub-plot with the bounty hunter looking to capture him, on turn in afterwards reward of 42$ and error:
Error: Unknown ASL command 500
Context= V= 2 1

[JohnnyDmonic]

Picked up a lancemate via a distress call random mission on spinner main map, was at lance limit, picked one to drop to bring in the new guy and...it appearantly deleted his mecha but kept the pilot?  Which is nice, cause the newbie is kinda junk and I'd have felt worse if I lost my Arena Pilot , Friend I got from doing arenas then letting him win the race to the cargo hold.

[Joseph Hewitt]

Picked up a lancemate via a distress call random mission on spinner main map, was at lance limit, picked one to drop to bring in the new guy and...it appearantly deleted his mecha but kept the pilot?  Which is nice, cause the newbie is kinda junk and I'd have felt worse if I lost my Arena Pilot , Friend I got from doing arenas then letting him win the race to the cargo hold.

Fixed the problem with Kolo, can't quite figure out what you mean here. Whose mecha got deleted?

[JohnnyDmonic]

The lancemate I chose to remove in order to take the new lancemate, his mecha got deleted, but he stayed in the lance.  I gave him a new mech and had an extra lancemate till the next time I picked someone up when I had to get rid of 2 in order to bring in the new one.  If I had to guess, I'd assume it had something to do with it being in the middle of a Scale 2 map when the dialog came up?  Or maybe it was just random weirdness.

[Joseph Hewitt]

I would guess that the routine which removes lancemates from your party didn't count on the lancemate being in a mecha, so treated the mecha as the lancemate. It probably moved the mecha to a safe, public building and set its team value to Citizens. The mecha will never be deployed because it's too big for the scene it's in, but it's probably still there, somewhere.

I'm not entirely sure how you kept the lancemate, though. I would have thought that if the lancemate remover treated the mecha as a lancemate it would have moved the mecha before the DelinkJjang procedure could remove the pilot. I'll look into it tomorrow; this seems like the kind of bug which should be relatively easy to fix.

[Daemonward]

In GH2 v0.624, the Ramstein's lance cannon is EMPTY. I checked the design file and it looks like the 'magazine 100' line is in the ammo subsection instead of the gun section.

[JohnnyDmonic]

Cayley Mine

SPOILER WARNING


Data Slate on apply code breaking:

Warning: Script value AS_MEDICAL in Data Slate
Context: 200 SKILLXP something something

[JohnnyDmonic]

Weird formatting error in the response text to turning down a lancemate from the corestory.
"Well if you ever have need of her, Piveta will be waiting at Aroura Night. Thanks a(non-standard ascii gibberish)gain for your help."

[CCC]

On occasion, a robot will train more than one skill when you ask it to train. Sometimes, when it does this, the robot will end up with negative free XP.

I've found out why. In the file pcaction.pp, the function AutoTraining, the variable FXP is set to the amount of free XP that the robot has. The number of skills that can be trained is counted, and one of these skills is set at random (by picking a random value N, counting down among skills that can be improved until you hit zero).

Then the skill is improved. That is, the skill level is increased by one and the amount of spent XP is reduced by the requisite amount. However, and this is important, the variable FXP is not reduced. N is reset to 5 (I do not see why this should be a fixed, non-random value) and the countdown continues; if N reaches 0 in time to improve another skill, then the cost of the skill is checked against FXP to see if it can be improved. (So if you started with 400XP free, the function can improve two skills at 300XP each, leaving the robot with -200XP. If the robot has enough skills, it can even theoretically improve a third 300XP skill, leaving the robot at -500XP).

I can see two ways to fix this bug; either update FXP when the amount of spent XP changes, or don't reset the value of N to five after training a skill. (Not resetting the value of N to 5 also prevents the system from being more likely to train the later skills on the list, if possible; it does mean that training a robot until it has spent all the experience it can may require the user to tell it to train several times, though, as it will then only autotrain one skill for one level each time).

[CCC]

Entered a temporary location, in which there were several rats and a death rat. And a big cheese, which was presumably why they were there. It's a but because the location was hard vacuum (space-based location, followed a treasure map I got from some pirates, looking for and finding the chitin breastplate). The rats had all asphyxiated before I got close to them.

[IsharaComix]

Hi all - this is my first post. I'm piggybacking a bug report since that seems to be the standard here.

Whenever I complete a mission in space (generic 'stop the people we don't like' mission), I usually call my employer and get my reward before I leave the scene of the battle.

Since upgrading to 624 from 622, every time I do that, I get an 'ERROR: No PC on map' message when I leave the battlefield. It doesn't seem to cause any lasting damage and if I do it when I arrive at the spinner, then the error doesn't appear.